Add Assert-RequiredCommandParameter and Test-AccountRequirePassword
#94
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See if |
Codecov Report
@@ Coverage Diff @@
## main #94 +/- ##
==================================
Coverage 91% 91%
==================================
Files 29 31 +2
Lines 548 568 +20
==================================
+ Hits 499 519 +20
Misses 49 49
|
johlju
commented
Dec 30, 2022
There was a problem hiding this comment.
Reviewed 1 of 9 files at r1, 8 of 11 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: 10 of 12 files reviewed, all discussions resolved
johlju
commented
Dec 30, 2022
There was a problem hiding this comment.
Reviewed 2 of 11 files at r3.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @johlju)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Assert-RequiredCommandParameterthat throws anexception if a specified parameter is not assigned a value, and optionally
throws only if a specific parameter is passed. - Issue #92
Test-AccountRequirePasswordthat returns true orfalse whether an account need a password to be passed - Issue #93
Assert-BoundParameterAssert-RequiredCommandParameterwhich will throw an exception if a specified parameter is not assigned
a value, and optionally throws only if a specific parameter is passed.
Assert-ElevatedUserandTest-IsNumericTypesothe public function is tested correctly using the exported function.
This Pull Request (PR) fixes the following issues
Task list
file CHANGELOG.md. Entry should say what was changed and how that
affects users (if applicable), and reference the issue being resolved
(if applicable).
DSC Community Testing Guidelines.
This change is